BerkeleyLearnVerify / Scenic

A compiler and scenario generator for the Scenic scenario description language.
https://scenic-lang.org/
Other
258 stars 93 forks source link

Fix drivable region #194

Closed dfremont closed 9 months ago

dfremont commented 9 months ago

Network.roadRegion can contain some points slightly outside of Network.laneRegion, because roads are formed as unions of their lanes with buffering+erosion to remove small gaps. Since we compute drivableRegion using laneRegion (unioned with intersectionRegion), this means that points at a distance from drivableRegion greater than the network tolerance can still have a road at them (according to Network.roadAt etc.). This caused a test failure in PR #178.

This PR adds roadRegion to drivableRegion to remove the discrepancy above. I've also robustified some of the road network tests that have failed recently so that hopefully in the future they will fail closer to when the actual bug is introduced rather than taking several CI runs to first turn up.