search

BerkeleyLearnVerify / Scenic

A compiler and scenario generator for the Scenic scenario description language.
https://scenic-lang.org/
Other
274 stars 92 forks source link

Visible/Non Visible Specifier Changes #214

Closed Eric-Vin closed 5 months ago

Eric-Vin commented 8 months ago

The visible/non visible specifiers now specify position considering the whole occupied space rather than just the position. For example, this means visible can place objects that have a corner visible, and not visible can place objects that are behind walls.

Eric-Vin commented 8 months ago

Going to wait for https://github.com/BerkeleyLearnVerify/Scenic/pull/213 to be merged in, so I can merge in main and fix the formatting check.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 97.49104% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.15%. Comparing base (d5a21fc) to head (35fa757). Report is 4 commits behind head on main.

Files Patch % Lines
src/scenic/core/regions.py 94.20% 4 Missing :warning:
src/scenic/core/pruning.py 96.77% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #214 +/- ## ========================================== + Coverage 85.89% 86.15% +0.26% ========================================== Files 144 144 Lines 24767 24938 +171 ========================================== + Hits 21274 21486 +212 + Misses 3493 3452 -41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.