BerkeleyLearnVerify / Scenic

A compiler and scenario generator for the Scenic scenario description language.
https://scenic-lang.org/
Other
256 stars 91 forks source link

Color tweaks. #240

Closed Eric-Vin closed 2 months ago

Eric-Vin commented 2 months ago

Description

Updated color specification process to ensure we have a unified internal representation and ensure we pass colors to Trimesh in the correct form. Tested on test suite and examples.

Issue Link

N/A

Checklist

Additional Notes

N/A

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.13%. Comparing base (7f018e0) to head (5f333fe).

Files Patch % Lines
src/scenic/core/object_types.py 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #240 +/- ## ======================================= Coverage 86.13% 86.13% ======================================= Files 144 144 Lines 24938 24956 +18 ======================================= + Hits 21480 21497 +17 - Misses 3458 3459 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Eric-Vin commented 2 months ago

Unfortunately I haven't found a way to open the Trimesh viewer when running pytest, at least on my machine. I can definitely add the length test though.