Closed dfremont closed 2 months ago
@dfremont regarding:
Once the CARLA CI is set up we can add tests for this conversion; there isn't really anything we can add to the main test suite, unfortunately.
What tests did you have in mind for the CI?
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 86.15%. Comparing base (
1c49d80
) to head (e8bdeb1
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/scenic/simulators/carla/utils/utils.py | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Fixes the conversions between Scenic orientations and CARLA rotations so that they work for arbitrary 3D orientations.
Issue Link
176 was probably a combination of this bug and the broader Scenic bug fixed in #241; this PR fixes the scenario provided in #176.
Checklist
pytest
and/or other meansAdditional Notes
Once the CARLA CI is set up we can add tests for this conversion; there isn't really anything we can add to the main test suite, unfortunately.
For future reference, the discussion of CARLA's conventions for rotations in #176 was wrong (CARLA's documentation is absolutely unhelpful here): in the course of fixing this issue I determined by experiment that CARLA uses the same ZXY intrinsic rotation sequence as Scenic, except that the Z rotation (yaw) is left-handed and the global orientation points East. I've added a comment to this effect in the code.