BerkeleyLearnVerify / Scenic

A compiler and scenario generator for the Scenic scenario description language.
https://scenic-lang.org/
Other
256 stars 91 forks source link

fix: Apple Silicon devices can generate multiple scenarios #248

Open abanuelo opened 2 months ago

abanuelo commented 2 months ago

Description

For this fix, I noticed that when if we use pyglet>=1.5.28 in our pyproject.toml it will use default to shutting down the generated Scenario immediately after the .show() is called to render the trimesh Scene. To resolve this I played with installing earlier versions of pyglet and landed on 1.5.26 as a good alternative to allow us to create multiple scenarios on Apple silicon devices, as is the expected behavior. Below is a video illustrating the fix:

https://github.com/BerkeleyLearnVerify/Scenic/assets/32311654/4c439741-985d-44b4-80f5-5978f785d3c6

Issue Link

230

Checklist

Additional Notes

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.11%. Comparing base (747f211) to head (030c288). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #248 +/- ## ========================================== - Coverage 86.15% 86.11% -0.05% ========================================== Files 144 144 Lines 24949 24984 +35 ========================================== + Hits 21494 21514 +20 - Misses 3455 3470 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Eric-Vin commented 2 months ago

Hmm, I'm hesitant to pin a specific version since we might block downstream users who are using Scenic as a library. Is this a bug fix where we can set a floor instead?

abanuelo commented 2 months ago

@dfremont and I discussed the proposed fix in this PR and he suggested we make the cieling for pyglet 1.5.26 but if trimesh does upgrade its library to support >2.0 pyglet we can adjust accordingly.