BerkeleyLearnVerify / Scenic

A compiler and scenario generator for the Scenic scenario description language.
https://scenic-lang.org/
Other
256 stars 91 forks source link

Add Tox plugin to work around cyclic dependency on verifai #251

Closed dfremont closed 2 months ago

dfremont commented 2 months ago

Description

The tox environments with the test-full extra (py38-extras etc.) recently broke, since they install verifai, whose cyclic dependency on scenic causes issues with the way that tox installs dependencies (see discussion here). Until we get a better solution, this PR adds a Tox plugin which works around the problem.

Issue Link

n/a

Checklist

Additional Notes

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.12%. Comparing base (d846a15) to head (6643011).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #251 +/- ## ========================================== + Coverage 86.10% 86.12% +0.01% ========================================== Files 144 144 Lines 24984 24986 +2 ========================================== + Hits 21512 21518 +6 + Misses 3472 3468 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Eric-Vin commented 2 months ago

Looks good to me, though I hope we can get a permanent solution soon.