Closed dfremont closed 2 months ago
Attention: Patch coverage is 96.15385%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 86.12%. Comparing base (
9ba90a3
) to head (2a2569f
).
Files | Patch % | Lines |
---|---|---|
tests/syntax/test_verifai_samplers.py | 96.07% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
The tests for the interface with VerifAI's cross-entropy sampler keep failing occasionally since I chose the parameters poorly. This PR improves the tests in various ways and should ensure the false positive rate is extremely low. In the process I noticed an issue whereby the distribution of one sampling run would leak into the next (even after calling
resetExternalSampler
), so I've fixed that and added an assertion catching it.Issue Link
n/a
Checklist
pytest
and/or other meansAdditional Notes