BerkeleyLearnVerify / Scenic

A compiler and scenario generator for the Scenic scenario description language.
https://scenic-lang.org/
Other
274 stars 92 forks source link

All examples within `examples/webots/road` are using an older version of Webots #262

Open abanuelo opened 4 months ago

abanuelo commented 4 months ago

System Details

  1. Python Version: 3.10.12
  2. Scenic Version: 3.0.0b2
  3. Operating System: Linux
  4. Simulator Version: Webots 2023a

Detailed Description

  1. The .wbt world files richmond.wbt, berkeley.wbt, mcity.wbt, simple.wbt, and southside2.wbt are using syntax of an older version of Webots, namely R2018b.
  2. Scenic runs when you import the .wbt file into Webots
  3. The error logs for each of these world files follow a similar flavor
    WARNING: '/home/ubuntu/actions/Scenic/examples/webots/road/simple.wbt': This file was created with Webots R2018b while you are using Webots R2023a. You may need to adjust urls for textures and meshes, see details in the change log of Webots R2021b.
    ERROR: Please adapt your project to R2023a following these instructions: https://github.com/cyberbotics/webots/wiki/How-to-adapt-your-world-or-PROTO-to-Webots-R2022b
    WARNING: '/home/ubuntu/actions/Scenic/examples/webots/road/simple.wbt': This file was created with Webots R2018b while you are using Webots R2023a. You may need to adjust urls for textures and meshes, see details in the change log of Webots R2021b.
    ERROR: Missing declaration for 'Road', add: 'EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/R2023a/projects/objects/road/protos/Road.proto"' to '/home/ubuntu/actions/Scenic/examples/webots/road/simple.wbt'.
    ERROR: '/home/ubuntu/actions/Scenic/examples/webots/road/simple.wbt':9:3: error: Skipped unknown 'dashedLine' parameter in Road PROTO.
    WARNING: '/home/ubuntu/actions/Scenic/examples/webots/road/simple.wbt': added missing WorldInfo node.
    WARNING: '/home/ubuntu/actions/Scenic/examples/webots/road/simple.wbt': added missing Viewpoint node.
    INFO: You are using a world from an old version of Webots. The backwards compability algorithm will try to convert it. Refer to the wiki for more information: https://github.com/cyberbotics/webots/wiki/How-to-adapt-your-world-or-PROTO-to-Webots-R2022a
    INFO: Viewpoint: Trying to resolve the backwards compability by adjusting the rotation (strategy A1).

Steps To Reproduce

  1. Load Webots > 2022b
  2. Import a world file from those mentioned above.
  3. Click run

Note that this issue is related to #260 which was decided that we would not directly support versions of webots < 2022a as some breaking changes were introduced in later versions of webots. Question: should remove these files from the repository or work on them to get them compatible with newer versions of Webots

Issue Submission Checklist

abanuelo commented 4 months ago

Also it's a bit unclear if these examples should just be run via the command-line since the README.md for that folder specifies how to do so: https://github.com/BerkeleyLearnVerify/Scenic/blob/main/examples/webots/road/README.md

abanuelo commented 4 months ago

Working to create documentation on how to push in OpenStreetMap data and a single working example within the roads directory to be able to run with Scenic.