Fixes problem with VerifaiSampler where there may be strange behavior when there are more than 10 samples in the scene. The problem is similar to the problem that was fixed recently in the VerifAI repo. The enumeration of objects goes as follows if there are more than 10 objects: 0, 1, 10, 2, 3, …, 9 when it expects 0, 1, 2, 3, …, 10 which causes a mismatch. This PR should fix this issue by checking that the parameter names match.
This issue might pop up for other external samplers as well, but VerifaiSampler is fixed at least.
Issue Link
276
Checklist
[x] I have tested the changes locally via pytest and/or other means
[ ] I have added or updated relevant documentation
[x] I have autoformatted the code with black and isort
Description
Fixes problem with
VerifaiSampler
where there may be strange behavior when there are more than 10 samples in the scene. The problem is similar to the problem that was fixed recently in the VerifAI repo. The enumeration of objects goes as follows if there are more than 10 objects: 0, 1, 10, 2, 3, …, 9 when it expects 0, 1, 2, 3, …, 10 which causes a mismatch. This PR should fix this issue by checking that the parameter names match.This issue might pop up for other external samplers as well, but
VerifaiSampler
is fixed at least.Issue Link
276
Checklist
pytest
and/or other meansAdditional Notes
N/A