BerkeleyLearnVerify / Scenic

A compiler and scenario generator for the Scenic scenario description language.
https://scenic-lang.org/
Other
276 stars 93 forks source link

Requirement Boolean Negation Fix #289

Closed Eric-Vin closed 3 months ago

Eric-Vin commented 3 months ago

Description

Fixes an issue where not inside a requirement is not handled correctly.

Issue Link

https://github.com/BerkeleyLearnVerify/Scenic/issues/286

Checklist

Additional Notes

N/A

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.30%. Comparing base (d7679fb) to head (742f4a7). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/BerkeleyLearnVerify/Scenic/pull/289/graphs/tree.svg?width=650&height=150&src=pr&token=HN3J4Y6F89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BerkeleyLearnVerify)](https://app.codecov.io/gh/BerkeleyLearnVerify/Scenic/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BerkeleyLearnVerify) ```diff @@ Coverage Diff @@ ## main #289 +/- ## ========================================== - Coverage 91.32% 91.30% -0.03% ========================================== Files 54 54 Lines 13515 13540 +25 ========================================== + Hits 12343 12363 +20 - Misses 1172 1177 +5 ``` | [Files](https://app.codecov.io/gh/BerkeleyLearnVerify/Scenic/pull/289?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BerkeleyLearnVerify) | Coverage Δ | | |---|---|---| | [src/scenic/core/requirements.py](https://app.codecov.io/gh/BerkeleyLearnVerify/Scenic/pull/289?src=pr&el=tree&filepath=src%2Fscenic%2Fcore%2Frequirements.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BerkeleyLearnVerify#diff-c3JjL3NjZW5pYy9jb3JlL3JlcXVpcmVtZW50cy5weQ==) | `95.23% <100.00%> (+0.03%)` | :arrow_up: | | [src/scenic/syntax/compiler.py](https://app.codecov.io/gh/BerkeleyLearnVerify/Scenic/pull/289?src=pr&el=tree&filepath=src%2Fscenic%2Fsyntax%2Fcompiler.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BerkeleyLearnVerify#diff-c3JjL3NjZW5pYy9zeW50YXgvY29tcGlsZXIucHk=) | `98.47% <100.00%> (+0.02%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/BerkeleyLearnVerify/Scenic/pull/289/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BerkeleyLearnVerify)