search

BerkeleyLearnVerify / Scenic

A compiler and scenario generator for the Scenic scenario description language.
https://scenic-lang.org/
Other
271 stars 93 forks source link

fix: shut down instance after workflow finishes #293

Open abanuelo opened 1 month ago

abanuelo commented 1 month ago

Description

As part of enhancing the simulator CI, we are introducing a condition for the stop_ec2_instance step that will get triggered regardless of success or failures of previous steps in the run to ensure that the instance is always stopped after a run.

Issue Link

Checklist

Additional Notes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.36%. Comparing base (f2c61b1) to head (537fa7a).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/BerkeleyLearnVerify/Scenic/pull/293/graphs/tree.svg?width=650&height=150&src=pr&token=HN3J4Y6F89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BerkeleyLearnVerify)](https://app.codecov.io/gh/BerkeleyLearnVerify/Scenic/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BerkeleyLearnVerify) ```diff @@ Coverage Diff @@ ## main #293 +/- ## ========================================== + Coverage 91.34% 91.36% +0.02% ========================================== Files 54 54 Lines 13535 13540 +5 ========================================== + Hits 12363 12371 +8 + Misses 1172 1169 -3 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/BerkeleyLearnVerify/Scenic/pull/293/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BerkeleyLearnVerify)