BerkeleyTrue / react-material

Material design components written with React.js and React Style
http://berkeleytrue.github.io/react-material
404 stars 38 forks source link

Dialog should take event not ReactElement #104

Closed BerkeleyTrue closed 6 years ago

BerkeleyTrue commented 9 years ago

Right now Dialog takes a ReactNode and uses that to determine where to start dialog transitions.

This seems like a bad code smell. Instead we can pass in an event object instead and use that to determine where to start the dialog animations