search

BerkeleyTrue / react-material

Material design components written with React.js and React Style
http://berkeleytrue.github.io/react-material
404 stars 38 forks source link

Revert textfield changes #66

Closed SanderSpies closed 9 years ago

SanderSpies commented 9 years ago

As of today I've got access to Android L on my phone, and I noticed that our animation happens nowhere... Also if I check the design documents I can't find any mention of it. So I'm afraid we'll have to revert the animation. I might be missing something?

/cc @robertknight

robertknight commented 9 years ago

The Material Design specs themselves don't specify animations as far as I can see. I based them off the <paper-input> element from Google's Polymer's Paper Elements (https://www.polymer-project.org/docs/elements/paper-elements.html).

I have a 2013 Nexus 7 but it hasn't yet received an OTA update to Android L to try out.

There are a few possibilities - perhaps the animation specs changed at some point and Polymer wasn't updated, or perhaps the animation is only supposed to be shown in certain circumstances. Perhaps we could ask a knowledgeable Googler?

SanderSpies commented 9 years ago

Asked the Polymer team, who are practically Google: https://github.com/Polymer/paper-input/issues/106

robertknight commented 9 years ago

Polymer team confirmed that the cursor animation has been removed from MD specs. The underline animation is still there. I'll submit a PR to remove the cursor anim.

SanderSpies commented 9 years ago

:+1: