Possible memory leak with RippleContainer

BerkeleyTrue / react-material

Material design components written with React.js and React Style

http://berkeleytrue.github.io/react-material

404 stars 38 forks source link

Possible memory leak with RippleContainer #85

Closed phated closed 6 years ago

phated commented 9 years ago

I've been working with the List and ListItem components and end up with immediate tab crashes. When I add the disableRipple property to the ListItem component, I no longer have the crashing. Haven't dug into why or where this is happening inside of RippleContainer.

SanderSpies commented 9 years ago

Yeah, some ugly DOM event listeners are being used which might be the reason for these errors. Wish we could use React's nice virtual event system here.