search

BerkeleyTrue / react-material

Material design components written with React.js and React Style
http://berkeleytrue.github.io/react-material
404 stars 38 forks source link

All components should allow styles to be added or overridden #86

Closed phated closed 6 years ago

phated commented 9 years ago

Working with the Card component, I noticed that I was unable to pass styles to it and override or add to the default styles. Every component should allow for styles to be overridden or added.

SanderSpies commented 9 years ago

Yes definitely, in our case it actually might make sense to have a parent component from which all components inherit as we are in control of the parent component. So something like: 

class Button extends MaterialComponent
...
class MaterialComponent extends React.Component

might make sense.

BerkeleyTrue commented 9 years ago

@SanderSpies I think having HOC instead of creating more subclasses would be better. Something to think about.