BerkeleyTrue / react-redux-epic

37 stars 13 forks source link

Update redux-observable to version 0.17.0 #25

Closed jdachtera closed 6 years ago

jdachtera commented 6 years ago

Hey, I updated redux-observable dependency to version 0.17.0

The tests run fine:

→ npm run test

> react-redux-epic@1.0.0 pretest /Users/jascha/dev/react-redux-epic
> npm run lint

> react-redux-epic@1.0.0 lint /Users/jascha/dev/react-redux-epic
> eslint src test

> react-redux-epic@1.0.0 test /Users/jascha/dev/react-redux-epic
> NODE_ENV=test nyc ava

  28 passed
---------------------|----------|----------|----------|----------|----------------|
File                 |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
---------------------|----------|----------|----------|----------|----------------|
All files            |    90.91 |    88.89 |    82.61 |    91.86 |                |
 contain.js          |    96.67 |     87.5 |      100 |    96.67 |            105 |
 index.js            |      100 |      100 |      100 |      100 |                |
 render-to-string.js |      100 |      100 |      100 |      100 |                |
 render.js           |        0 |      100 |        0 |        0 |... 12,13,16,19 |
 symbols.js          |      100 |      100 |      100 |      100 |                |
 wrap-root-epic.js   |      100 |      100 |      100 |      100 |                |
---------------------|----------|----------|----------|----------|----------------|
coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 91.346% when pulling 830a7cd63aac13d155c6af6471b24e3f2d650c01 on jdachtera:redux-observable-0.17.0 into e6791ec266533ba59e19d3af3b0eb030560c8472 on BerkeleyTrue:master.

jdachtera commented 6 years ago

@BerkeleyTrue, any chance to get this merged? I'm getting mixed versions of redux-observable and thus can't update to 0.17.0

BerkeleyTrue commented 6 years ago

The semvar range here should accept 0.17.0 as a valid package. Have you tried to dedupe?

jdachtera commented 6 years ago

I thought the same but unless I'm missing something it doesn't seem to be the case with both yarn and npm. Could it be that these semver rules don't apply to pre releases (below 1.0.0 versions)?

$ yarn add react-redux-epic redux-observable@0.17.0
...

$ yarn list
Output ``` yarn list v1.3.2 warning package.json: No license field warning No license field ├─ asap@2.0.6 ├─ babel-runtime@6.26.0 │ ├─ core-js@^2.4.0 │ └─ regenerator-runtime@^0.11.0 ├─ core-js@2.5.3 ├─ debug@3.1.0 │ └─ ms@2.0.0 ├─ encoding@0.1.12 │ └─ iconv-lite@~0.4.13 ├─ fbjs@0.8.16 │ ├─ core-js@^1.0.0 │ ├─ core-js@1.2.7 │ ├─ isomorphic-fetch@^2.1.1 │ ├─ loose-envify@^1.0.0 │ ├─ object-assign@^4.1.0 │ ├─ promise@^7.1.1 │ ├─ setimmediate@^1.0.5 │ └─ ua-parser-js@^0.7.9 ├─ iconv-lite@0.4.19 ├─ invariant@2.2.2 │ └─ loose-envify@^1.0.0 ├─ is-stream@1.1.0 ├─ isomorphic-fetch@2.2.1 │ ├─ node-fetch@^1.0.1 │ └─ whatwg-fetch@>=0.10.0 ├─ js-tokens@3.0.2 ├─ lodash-es@4.17.4 ├─ lodash@4.17.4 ├─ loose-envify@1.3.1 │ └─ js-tokens@^3.0.0 ├─ ms@2.0.0 ├─ node-fetch@1.7.3 │ ├─ encoding@^0.1.11 │ └─ is-stream@^1.0.1 ├─ object-assign@4.1.1 ├─ promise@7.3.1 │ └─ asap@~2.0.3 ├─ prop-types@15.6.0 │ ├─ fbjs@^0.8.16 │ ├─ loose-envify@^1.3.1 │ └─ object-assign@^4.1.1 ├─ react-dom@16.2.0 │ ├─ fbjs@^0.8.16 │ ├─ loose-envify@^1.1.0 │ ├─ object-assign@^4.1.1 │ └─ prop-types@^15.6.0 ├─ react-redux-epic@1.0.0 │ ├─ babel-runtime@^6.11.6 │ ├─ debug@^3.1.0 │ ├─ invariant@^2.2.1 │ ├─ react-dom@^16.0.0 │ ├─ react@^16.0.0 │ ├─ redux-observable@^0.16.0 │ ├─ redux-observable@0.16.0 │ ├─ redux@^3.6.0 │ └─ rxjs@^5.3.0 ├─ react@16.2.0 │ ├─ fbjs@^0.8.16 │ ├─ loose-envify@^1.1.0 │ ├─ object-assign@^4.1.1 │ └─ prop-types@^15.6.0 ├─ redux-observable@0.17.0 ├─ redux@3.7.2 │ ├─ lodash-es@^4.2.1 │ ├─ lodash@^4.2.1 │ ├─ loose-envify@^1.1.0 │ ├─ symbol-observable@^1.0.3 │ └─ symbol-observable@1.2.0 ├─ regenerator-runtime@0.11.1 ├─ rxjs@5.5.6 │ └─ symbol-observable@1.0.1 ├─ setimmediate@1.0.5 ├─ symbol-observable@1.0.1 ├─ ua-parser-js@0.7.17 └─ whatwg-fetch@2.0.3 ✨ Done in 0.17s. ```

Same with npm:

$ npm install --save react-redux-epic redux-observable@0.17.0
...
$ npm dedupe
up to date in 0.217s
$ npm list
Output ``` react-redux-epic-test@1.0.0 /Users/jascha/dev/react-redux-epic-test ├─┬ react-redux-epic@1.0.0 │ ├─┬ babel-runtime@6.26.0 │ │ ├── core-js@2.5.3 │ │ └── regenerator-runtime@0.11.1 │ ├─┬ debug@3.1.0 │ │ └── ms@2.0.0 │ ├─┬ invariant@2.2.2 │ │ └─┬ loose-envify@1.3.1 │ │ └── js-tokens@3.0.2 │ ├─┬ react@16.2.0 │ │ ├─┬ fbjs@0.8.16 │ │ │ ├── core-js@1.2.7 │ │ │ ├─┬ isomorphic-fetch@2.2.1 │ │ │ │ ├─┬ node-fetch@1.7.3 │ │ │ │ │ ├─┬ encoding@0.1.12 │ │ │ │ │ │ └── iconv-lite@0.4.19 │ │ │ │ │ └── is-stream@1.1.0 │ │ │ │ └── whatwg-fetch@2.0.3 │ │ │ ├── loose-envify@1.3.1 deduped │ │ │ ├── object-assign@4.1.1 deduped │ │ │ ├─┬ promise@7.3.1 │ │ │ │ └── asap@2.0.6 │ │ │ ├── setimmediate@1.0.5 │ │ │ └── ua-parser-js@0.7.17 │ │ ├── loose-envify@1.3.1 deduped │ │ ├── object-assign@4.1.1 │ │ └─┬ prop-types@15.6.0 │ │ ├── fbjs@0.8.16 deduped │ │ ├── loose-envify@1.3.1 deduped │ │ └── object-assign@4.1.1 deduped │ ├─┬ react-dom@16.2.0 │ │ ├── fbjs@0.8.16 deduped │ │ ├── loose-envify@1.3.1 deduped │ │ ├── object-assign@4.1.1 deduped │ │ └── prop-types@15.6.0 deduped │ ├─┬ redux@3.7.2 │ │ ├── lodash@4.17.4 │ │ ├── lodash-es@4.17.4 │ │ ├── loose-envify@1.3.1 deduped │ │ └── symbol-observable@1.2.0 │ ├── redux-observable@0.16.0 │ └─┬ rxjs@5.5.6 │ └── symbol-observable@1.0.1 └── redux-observable@0.17.0 ```
BerkeleyTrue commented 6 years ago

Well, that's pretty annoying. It maybe a better option to move these to peerdeps. That way the project version will be the only one installed

BerkeleyTrue commented 6 years ago

Actually the changes in 0.17 are significant to warrant a bump release.

BerkeleyTrue commented 6 years ago

release as v1.1.0

jdachtera commented 6 years ago

Great, thanks a lot!

BerkeleyTrue commented 6 years ago

Happy Coding.