BerkeleyTrue / react-redux-epic

37 stars 13 forks source link

Enable compatibility with redux-observable@1.x, redux@4.x and rxjs@6.x #37

Closed jdachtera closed 3 years ago

jdachtera commented 5 years ago

Hi @BerkeleyTrue,

This pr enables compatibility with redux-observable@1.x, redux@4.x and rxjs@6.x. (without the need for the rxjs5 compat layer).

Let me know if you need anything to get this merged.

Cheers, Jascha

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.08%) to 91.429% when pulling c5ec31eb2a4c3a7d885e918fdf603a8cffd9d141 on jdachtera:feature/rxjs6+redux-observable1.0 into af034a4ace944f361b8f1490bfc66abb03736b35 on BerkeleyTrue:master.

jdachtera commented 5 years ago

@BerkeleyTrue, any chance to get this merged?

BentoumiTech commented 5 years ago

@jdachtera Probably some changes would be also needed in the docs/api/README.md as createEpicMiddleware signature changed.

jdachtera commented 5 years ago

@Neophy7e, thanks! I'll add that as soon as possible.

jdachtera commented 5 years ago

@NeoPhy7e, @BerkeleyTrue, added the the documentation changes. Let me know what you think!

BentoumiTech commented 5 years ago

@jdachtera @BerkeleyTrue I don't know if you were aware but there is currently two PR's in the redux-observable repo that aims to implement SSR directly in the library. Maybe your experience redux-observable and SSR could help out there.

jdachtera commented 5 years ago

@Neophy7e thanks for pointing this out. My impression of these discussions is that it doesn't seem to be easy to align on the technical implementation. Maybe then it's better to keep it as a separate library for now.

Also as a builtin feature it might increase the bundle size on the client side event though it would only be needed on the server.

Since there has been no activity by the maintainer I've published this under a new namespace for now so everyone can easily use it: https://www.npmjs.com/package/@jdachtera/react-redux-epic

Cheers!

BentoumiTech commented 5 years ago

@jdachtera Thank you for making it available through npm.