search

BerkieBb / pma-sirensync

The best siren sync resource to utilise in FiveM
MIT License
58 stars 21 forks source link

Can't turn off sirens IF #5

Closed iSentrie closed 1 year ago

iSentrie commented 1 year ago

Repro for a sirens bug, which breaks it from turning off.

  1. Turn on siren lighs
  2. Press Arrow up
  3. Press ,
  4. Press Arrow up
  5. You should be unable to turn off sirens.
BerkieBb commented 1 year ago

Yeah seems like the siren from the arrow up doesn't stop, I'll fix this later, but to stop the sirens from the comma key, just press the key .

iSentrie commented 1 year ago

Arrow up should be a toggle and it would be fine.

BerkieBb commented 1 year ago

Arrow up is not a toggle anymore

BerkieBb commented 1 year ago

After some feedback I made it a cycle through sounds only, it won't turm them off

BerkieBb commented 1 year ago

It should only turn off when disabling the lights

BerkieBb commented 1 year ago

Fixed the issue here https://github.com/BerkieBb/pma-sirensync/commit/d59de557aa12ed138978fa3d0c628ac5bc7713ab