Question Part 2 - Githubissues

DogsGoBark commented 1 year ago

As I asked in #2 I didn't notice you added support for Audio Banks, so my question is this the correct way?

export const PrimarySirenOverride: Map<number, string | string[]> = new Map<number, string | string[]>()
    .set(joaat("police3"), ["SIREN_ALPHA", "SIREN_BRAVO", "SIREN_CHARLIE"])

export const AddonAudioBanks: Map<string, string | string[]> = new Map<string, string | string[]>()
    .set("DLC_WMSIRENS\\SIRENPACK_ONE", "DLC_WMSIRENS\\SIRENPACK_ONE")

Or should it be

export const AddonAudioBanks: Map<string, string | string[]> = new Map<string, string | string[]>()
    .set("DLC_WMSIRENS", "SIRENPACK_ONE")

BerkieBb commented 1 year ago

Yeah it should be "audio bank name", "sound name in the audio bank"

BerkieBb commented 1 year ago

And if you have more sounds that you want to use, you use "audio bank name", ["audio1", "audio2", "etc"]

DogsGoBark commented 1 year ago

Sorry, a bit confused? Talking about the AddonAudioBanks

Option 1

export const PrimarySirenOverride: Map<number, string | string[]> = new Map<number, string | string[]>()
    .set(joaat("police3"), ["SIREN_ALPHA", "SIREN_BRAVO", "SIREN_CHARLIE"])

export const AddonAudioBanks: Map<string, string | string[]> = new Map<string, string | string[]>()
   .set("DLC_WMSIRENS\\SIRENPACK_ONE", "DLC_WMSIRENS\\SIRENPACK_ONE")

Option 2

export const AddonAudioBanks: Map<string, string | string[]> = new Map<string, string | string[]>()
   .set("DLC_WMSIRENS", "SIRENPACK_ONE")

BerkieBb commented 1 year ago

Yeah I told you what to put inside the set method of AddonAudioBanks

BerkieBb commented 1 year ago

.set("DLC_WMSIRENS\\SIRENPACK_ONE", ["SIREN_ALPHA", "SIREN_BRAVO", "SIREN_CHARLIE"]) It should be like this for the AddonAudioBanks

nggcasey commented 1 year ago

So I've go this, rebuilt the resource, still no luck - Still playing default sirens.

export const HornOverride: Map<number, string> = new Map<number, string>()
    .set(joaat("police3"), "VEHICLES_HORNS_FIRETRUCK_WARNING")

export const PrimarySirenOverride: Map<number, string | string[]> = new Map<number, string | string[]>()
    .set(joaat("police3"), ["SIREN_ALPHA", "SIREN_BRAVO", "SIREN_CHARLIE"])

export const AddonAudioBanks: Map<string, string | string[]> = new Map<string, string | string[]>()
    .set("DLC_WMSIRENS\\SIRENPACK_ONE", ["SIREN_ALPHA", "SIREN_BRAVO", "SIREN_CHARLIE", "SIREN_DELTA", "SIREN_ECHO", "SIREN_FOXTROT", "SIREN_GOLF", "SIREN_HOTEL"])

export const Debug: boolean = true;

Any suggestions?

BerkieBb commented 1 year ago

Did you try it with siren2, so the up arrow by default

nggcasey commented 1 year ago

Yeah - siren2 is activated, but no sound.

The HornOverride is working - I'm getting firetruck horns, and I've confirmed that the server sided sirens are working using the server sided audio tester.

MrNewb commented 1 year ago

same issue, looks like were both testing with the audio from https://github.com/Walsheyy/WMServerSirens.

just built from master branch

    .set(joaat("firetruk"), ["SIREN_ALPHA", "SIREN_BRAVO", "SIREN_CHARLIE", "SIREN_DELTA", "SIREN_ECHO", "SIREN_FOXTROT", "SIREN_GOLF", "SIREN_HOTEL"])
    .set(joaat("valor1rb"), ["SIREN_ALPHA", "SIREN_BRAVO", "SIREN_CHARLIE", "SIREN_DELTA", "SIREN_ECHO", "SIREN_FOXTROT", "SIREN_GOLF", "SIREN_HOTEL"])

export const AddonAudioBanks: Map<string, string | string[]> = new Map<string, string | string[]>()
    .set("DLC_WMSIRENS\\SIRENPACK_ONE", ["SIREN_ALPHA", "SIREN_BRAVO", "SIREN_CHARLIE", "SIREN_DELTA", "SIREN_ECHO", "SIREN_FOXTROT", "SIREN_GOLF", "SIREN_HOTEL"])

BerkieBb commented 1 year ago

I found the issue with it, I'm getting a fix for you guys

BerkieBb commented 1 year ago

https://github.com/BerkieBb/pma-sirensync/commit/a2abb8343d13a6e11c239854c973e6e8f9a7cb47 Could you try this fix and see if this works for you?