BerlinVagrant / vagrant-dns

A plugin to manage DNS records for vagrant environments
MIT License
490 stars 50 forks source link

fix issue when private_network is associated with dhcp type #39

Closed fhenri closed 7 years ago

fhenri commented 8 years ago

In the Vagrantfile, when the network setting is defined as config.vm.network "private_network", type: "dhcp" the plugin will not work and the vm machine is not accessible using the tld.

Is is referenced in

samdoran commented 7 years ago

I'd love to see this get merged. I just manually patched the plugin I have installed to get this working. Thanks for making such a usefuly plugin for Vagrant!

fnordfish commented 7 years ago

Sorry, that it took us that long to get this done. And many thanks for putting work into this project. I've decided to go a slightly other way than this PR, but again, thanks a lot.

Please check out vagrant-dns v1.1.0

Closed in favor of #50

samdoran commented 7 years ago

Thank you for fixing this. I really appreciate it.

fnordfish commented 7 years ago

btw. I'm currently working on a solution where you can provide a Proc in the Vagrant in order to determinate the vm (box) dhcp ip. (pretty much like the solution mentioned in the StackOverflow article above)

mpdude commented 7 years ago

Probably resolves #37 as well.

fnordfish commented 7 years ago

@mpdude Sorry, but this won't solve #37. The reason is, that vagrant-dns currently lacks a way to determinate the hosts IP after its network came up and got an IP assigned. I have a (kind of) working branch adding such a feature (#51) , but I'm waiting on mitchellh/vagrant#8500 to make it fully functional.