search

BerlinVagrant / vagrant-dns

A plugin to manage DNS records for vagrant environments
MIT License
490 stars 50 forks source link

Updated readme with multivm config #63

Closed murarisumit closed 5 years ago

murarisumit commented 5 years ago

Added example of multivm config.

All thanks to @fnordfish for help in https://github.com/BerlinVagrant/vagrant-dns/issues/62.

fnordfish commented 5 years ago

Hey Sumit,

Thanks. Just a few things:

In the markdown code block, you put “Vagrant” after the triple backticks - not sure if that will put the correct highlighting (couldn’t see it in the diff). Could you please change it to “ruby” (line 111)

The sample is quite big. I’d like to keep them focused to make it easier to spot the important bits. Can you please drop the “master” block and keep the “worker” stuff, maybe also thesubconfig.vm.provider Stuff

Sorry for so picky and again, thanks for making the effort

murarisumit commented 5 years ago

@fnordfish it make sense, have dropped master block and changed triple backticks to 'ruby'