search

Bernasss12 / BetterEnchantedBooks

Makes it easier to identify different enchantment books.
MIT License
12 stars 9 forks source link

[Feature Request] Option to disable the enchantment glint added by this mod #19

Closed Abbanon closed 3 years ago

Abbanon commented 3 years ago

I've noticed this mod adds an extra layer of enchantment glint on top of the default enchantment glint layer, making it appear much more opaque and harder to see the book texture underneath. It's even more obscured when you're using resource packs with custom enchantment glint textures. Any way we could have a toggle to disable the extra glint layer this mod adds to the enchanted books?

Bernasss12 commented 3 years ago

Could you please show what you mean with extra layer and more obscure? All the mod does is add a different glint texture just like a texture pack would, and in case a texture pack does change the glint it's supposed to override it

Abbanon commented 3 years ago

I'm unable to get it in motion, but here's some screenshots I've taken. Left is an enchanted book from this mod, and right is a regular written book. The enchantment glint on books from this mod is much more bright and opaque compared to normal, almost like it's applying the texture more than once. It also moves in a bit of a different pattern compared to regular. (Edit: This is with a custom enchantment glint texture) 2020-11-05_11 54 36 2020-11-05_11 54 39 2020-11-05_11 54 13

Bernasss12 commented 3 years ago

That doesn't look like the going that ships with my mod actually, are you sure that happens without the resource pack active? I'm lookin into it but the "custom" glint is really just a texture and the rest is just vanilla

Abbanon commented 3 years ago

I can confirm it happens with vanilla textures as well. 2020-11-05_12 06 16 2020-11-05_12 06 30 2020-11-05_12 09 30 2020-11-05_12 17 32

Abbanon commented 3 years ago

I managed to record some videos of the animations in progress on the hotbar. Hope it helps to convey what's going on. example videos.zip

Bernasss12 commented 3 years ago

Can you tell me which version of the mod you are using?

FewerFlaws commented 3 years ago

I would also like an option to disable the enchantment glint. I've already got glints disabled on potions, and I think it's conceptually consistent for a dormant enchantment in a book to have no glint compared to an active enchantment on equipment.

Abbanon commented 3 years ago

Can you tell me which version of the mod you are using?

It's been happening for the last two or three versions, back when I first started using this mod. Still occurs on the latest (v1.1.4)

Weird double-layered glint issue aside, it would be nice to be able to toggle the custom glint brought by this mod on/off. I'm using a mod that disables the Enchanted Book glint entirely, and I only use this mod for the colour customization. I'd rather have the choice of using the vanilla glint texture.

Bernasss12 commented 3 years ago

As of the latest CurseForge release there is now an option to disable the glint on the enchanted books. Thanks for the feedback and sorry it took s long to finally come around to doing it.

Bernasss12 commented 3 years ago

I believe this should have fixed this issue, if not please feel free to reopen it or to open a new one.