search

Bernasss12 / BetterEnchantedBooks

Makes it easier to identify different enchantment books.
MIT License
12 stars 9 forks source link

[Feature Request] Show maximum enchantment level in tooltip #21

Closed maxsupermanhd closed 3 years ago

maxsupermanhd commented 3 years ago

Sometimes I just forget what's maximum level of enchantment, will be nice to have it in tooltip. Bet that's easy to make

Bernasss12 commented 3 years ago

How would you do something like that? Like Sharpness III/V? Could you please be more expressive about what you had in mind?

maxsupermanhd commented 3 years ago

Yeah, something like III/V will do perfectly fine. Actually any format will do, even ... III (max IV). It's up to you mostly, I just want it to be more accessible like so I can get this information from game itself without spending time getting second book or trying to level up maxed out enchantment. As I remember there is no way in default Minecraft to get max level information, only trip to the wiki...

PS I'm happy that you are alive, great mod, I enjoy it, thank you

Bernasss12 commented 3 years ago

Well thank you for that! I thought I had it all done but I guess this is a weird side-effect of how I tried to do it :) image I should have this fixed within the next hour

Bernasss12 commented 3 years ago

Done image

Bernasss12 commented 3 years ago

It's supposed to work with any added enchantments just like any other of my mod's features.

Bernasss12 commented 3 years ago

This is technically done but I guess maybe I should add an option where either the whole name is colored different if it at max level or the max level isn't shown in case the enchantment already is at max level or both maybe idk.

But that's a problem for the future, anyway, hope you enjoy the new feature! (it's disabled by default so you will need to change the settings for the mod)

maxsupermanhd commented 3 years ago

Thank you, I appreciate your work man.

As I understood from your messages here (not really understanding this mixin and stuff in java) it will detect available enchantments in game and get info about them or they are just yeet-hardcoded? (hope not)

Bernasss12 commented 3 years ago

Yeah everything should work with added enchantments. The only thing that is hard coded, and that I do plan to make configurable, is the list of items/icons that show on the tooltip. Every enchantment and the items they can be applied to are calculated at runtime and so it should work with any mods that add enchantments without any additional setup.