Bernasss12 / BetterEnchantedBooks

Makes it easier to identify different enchantment books.
MIT License
12 stars 9 forks source link

[Feature Request] Please rename your mixin methods #29

Closed SilverAndro closed 3 years ago

SilverAndro commented 3 years ago

Hi, your mod is causing a crash with my mod when I try to grab tool tips of items, but all the mixins appear as stuff like handler$kadwn$method17869Tail in the crash log which is completely useless

Could you rename your mixin methods to be what the mixin does and not where it is? Thanks

Bernasss12 commented 3 years ago

The mixin you are looking for is here

I'm probably not changing any of the code until I do a full mod rewrite so just feel free to ask me what each method does.

SilverAndro commented 3 years ago

I was able to find it and can mostly tell what it does, its just that without the ability to attribute mixins to JARs or at least have a good guess, it can be nigh-impossible to actually get bug reports to you

Bernasss12 commented 3 years ago

That's true and I understand what you mean but I still don't think I will revisit this code at the moment. I'm focusing on another project at the moment and the code base is too different for me to be hopping back and forth.