search

Bernasss12 / BetterEnchantedBooks

Makes it easier to identify different enchantment books.
MIT License
12 stars 9 forks source link

[Bug] CIT Resewn mod incompatibility (I think) #45

Closed alexmozaidze closed 1 year ago

alexmozaidze commented 2 years ago

Describe the bug The books that should've had a different texture look very broken to the point I barely can call them books, books that weren't changed (mainly modded ones) weren't affected by this bug. Tested with Xali's Enchanted Books resourcepack

Steps To Reproduce

  1. Install CIT Resewn along with BetterEnchantedBooks
  2. Put Xali's Enchanted Books into the resourcepacks directory
  3. Activate the resourcepack
  4. Look at the books, they look horrible!

Expected behavior BetterEnchantedBooks should not have changed the books that were retextured

Screenshots The three books on the bottom that look correct are the modded ones and weren't touched by the resourcepack 2021-09-19_20 08 34

Please include:

Bernasss12 commented 2 years ago

Could you try changing the settings of the mod? Disabling the colouring options for example? I would have to look into the CIT mod to deduce what to do and what could be conflicting.

alexmozaidze commented 2 years ago

I disabled coloring. Books, unfortunately, look as messed up, except that they are now one color 2021-09-20_15 21 02

Bernasss12 commented 2 years ago

So the only thing I can try to do is to change the way I'm coloring the strips, currently I'm applying a tint to every layer above layer0, I should really only be doing that to layer1. Other than that there's nothing I can do since CITResewn alters a lot of the loaded models to a degree I don't really fully compreend. So chances are this will not fix it but there's really not much I can think of to do so.

Boobies commented 2 years ago

Why is anything happening at all when coloring is disabled, though?

Bernasss12 commented 2 years ago

The coloring is something registered in fabric api at startup, when it's turned off it just sets the original book color. CIT resewn is changing the layer order making the colored layer (unused in vanilla) have the whole book texture

Boobies commented 2 years ago

Perhaps not use the mixin at all when CIT Resewn is present?

Bernasss12 commented 1 year ago

I'm going to call this a mod incompatibility for the time being with a chance of being fixed in the future, but not by "not working if x-mod is present"