Bernasss12 / BetterEnchantedBooks

Makes it easier to identify different enchantment books.
MIT License
12 stars 9 forks source link

[Bug] Tooltip icons in REI #49

Open Fourmisain opened 2 years ago

Fourmisain commented 2 years ago

The kinda bad news

Since https://github.com/Bernasss12/BetterEnchantedBooks/commit/d64e2df82b8f9259354c7522b0e306c87fd94dcf I was hoping that tooltip icons could finally be made to work in REI as well.

So I tried and this is the best I got so far: best

What I did is ripping out the ol' enchantedItemStack which I believe is completely superfluous now and was blocking the tooltip logic for no reason - but as you can see, instead of tooltip icons it drew "This is not supposed to be used as an actual string.", this is because REI thinks the tooltip is pure text and converts it to a string.

What you see at the bottom left is the result of adding a tooltip component (added similarly to https://github.com/shedaniel/RoughlyEnoughItems/issues/568) which isn't considered text, but this has the drawback of always being rendered at the bottom and as you can see, I couldn't get it to actually render on top of the tooltip (I offset it to be able to see it), despite trying all ways of changing the zOffset or actual z value.

You can find this code on my experimental branch.

The good news!

So while looking up the references to the relevant GitHub issues and REI code just now, I found this: https://github.com/shedaniel/RoughlyEnoughItems/issues/645

Apparently the AppleSkin author a very similar issue and there now seems to be an API for this!