Closed Fourmisain closed 2 years ago
As far as I can tell, the only thing that broke were the tooltip icons (again).
It was a simple one-line fix: IconTooltipComponent.drawItems() lost its TextureManager parameter.
IconTooltipComponent.drawItems()
TextureManager
Looks like I made a few small changes in https://github.com/Bernasss12/BetterEnchantedBooks/commit/11e80beb9ca293914a8bd495b917bb734fb82f95 too: Using remap = false and @Dynamic on lambda methods supresses some compile warnings.
remap = false
@Dynamic
Also, I finally learned how to change the PR target branch: You can create a new mc-1.18 branch and then change this PR's target branch to it by clicking "edit" on the top right.
mc-1.18
P.S. Inofficial release here
There we go, the fabric.mod.json and mixins.json are now updated too.
As far as I can tell, the only thing that broke were the tooltip icons (again).
It was a simple one-line fix:
IconTooltipComponent.drawItems()
lost itsTextureManager
parameter.Looks like I made a few small changes in https://github.com/Bernasss12/BetterEnchantedBooks/commit/11e80beb9ca293914a8bd495b917bb734fb82f95 too: Using
remap = false
and@Dynamic
on lambda methods supresses some compile warnings.Also, I finally learned how to change the PR target branch: You can create a new
mc-1.18
branch and then change this PR's target branch to it by clicking "edit" on the top right.P.S. Inofficial release here