Bernasss12 / BetterEnchantedBooks

Makes it easier to identify different enchantment books.
MIT License
12 stars 9 forks source link

[Feature Request] Customize the order of the enchantments on items in the tooltip. #60

Open PurPur134 opened 1 year ago

PurPur134 commented 1 year ago

When the option "Custom Order" is selected for the Tooltip Sorting Mode in the Config menu, it does not allow the user to customize how they want the enchantments to be ordered. The selected "Custom Order" options appears to be built in the mod.

Bernasss12 commented 1 year ago

Thank you for the report, custom order is indeed built in and does work (at least last I checked) but I have never really build the configuration GUI to do it in-game, currently the only way to change that order is to manually change the enchantment_data.json file in the config directory, for each enchantment there should be a orderIndex value and that's what the "Custom Order" option uses. I'm sorry for the inconvenience, I'll keep this issue open as a reminder to hopefully implement the in-game option sometime in the future.

EDIT: Hope this at least helps a little bit.

PurPur134 commented 1 year ago

Thank you for telling what file the built-in enchantment order is—that is a big help, and I can manually edit it to my preferences. I too hope someday that this feature will be fully implemented in-game.

PurPur134 commented 1 year ago

currently the only way to change that order is to manually change the enchantment_data.json file in the config directory, for each enchantment there should be a orderIndex value and that's what the "Custom Order" option uses.

I can't quite find the file enchantment_data.json nor the config directory in the .jar, is it somewhere else? I see it and orderIndex referenced in some files, but not the file nor the orderIndex value for each enchantment.

Bernasss12 commented 1 year ago

It should be next to the other mod's configs like this: image

Bernasss12 commented 4 months ago

This is kind of a thing now with the beta kotlin releases. Still haven't worked out a way to change the setting in-game but via the json files it's totally doable now!

PurPur134 commented 4 months ago

Nice, looks good! Thanks for still working on this.