search

BerndCirotzki / raymarine_autopilot_pi

Raymarine Autopilot Plugin for OpenCPN
GNU General Public License v3.0
7 stars 7 forks source link

Fix jammy builds and Language files #30

Closed rgleason closed 10 months ago

rgleason commented 10 months ago

Bernd, the PR and merge from your repo to mine built. I then fixed the jammy build following bdbcat's changes also updated TP FE2 files to 1.0.286.3

This should be it for now I think. Will push this 2.0.2.0 version up to plugins catalogs master branch where it will be available in PIM.

One question. This plugin is API 118, so it is for nmea2000, but your readme description says Seatalk 1. Shouldn't that be changed?

Also is there any way to make a new PI named and targeting Seatalk1 and nmea0183 so we don't leave some users behind? It would could use API117 and be built just for those? Or is there a way to continue using api118 and just make it for nmea0183 and Seatalk 1?

Sorry about the Language issues. In trying to get a handle on it, with Hakan's help we have some better documentation here https://github.com/jongough/testplugin_pi/issues/363

rgleason commented 10 months ago

Now made PR to opencpn/plugins to update the master catalog https://github.com/OpenCPN/plugins/pull/1064

Bdbcat will accept and merge it.

BerndCirotzki commented 10 months ago

Hello Rick, I think, you did not read the "readme" correct. The API118 can NMEA2000 and also NMEA0183. And in the plugin you can choose now what to use. either older Raymarine Seatalk1 Autopilots with NMEA0183 like before, or Raymarine EVO Autopilot with NMEA2000. The plugin chooses the right protocol to the connected Pilot which will be choosen in the preference dialog.

OK, this Version will nor work with OpenCPN 5.6.x and earlier, but for that there is the last version 1.0.41.0 that woks fine without NMEA2000, but OpenCPN 5.6.x has no NMEA2000. The 1.0.41.0 version has not the "AUTOCOG" feature, but that is not so important, and must be tested out a little. And if there is interest in this featue, it could be a incentive to upgrade to OpenCPN 5.8.x and up !

rgleason commented 10 months ago

This is great. It is a plugin that works for everyone essentially. I think we need to update the description.

  1. Certainly in the github documentation https://opencpn-manuals.github.io/main/autopilot-rm/0.1/index.html
  2. Also in the PIM plugin description if possible, keeping it very short.

Line 55: set(LONG_DESCRIPTION "Control Raymarine Autopilot using a NMEA0183 to ST1 Converter or NMEA2000 for EVO")

I think this covers this ok.
BerndCirotzki commented 10 months ago

... see here : https://github.com/rgleason/raymarine_autopilot_pi/blob/master/Autopilot%20description.pdf and here : https://github.com/rgleason/raymarine_autopilot_pi/blob/master/README.md

I think erverthing is discribed, but the opencpn-manual could be updated, if necessary. It's really old. I don't know who wrote the opencpn-manuals.