search

BernhardSchlegel / BierBot

Raspberry Pi powered, Brewing Software for iOS, Android and Desktop (Mash and Ferment)
Other
17 stars 5 forks source link

Misinterpretation of kd and kp when using three decimal places #23

Open jonathanschneider opened 2 years ago

jonathanschneider commented 2 years ago

When using the expert mode in the hardware setup, BierBot interprets both "," and "." as decimal points. This is good, as it's less prone to user error. However, when you use "." as a decimal point and use three decimal places, the "." suddenly is interpreted as a thousands separator instead (0.933 --> 933.0).

Entering the values with "." and three decimal places:

Screenshot 2021-07-29 at 20 29 17

Saved values after reloading the page:

Screenshot 2021-07-29 at 20 29 39

I only noticed the error when my BierBot wouldn't stop heating anymore...

BernhardSchlegel commented 2 years ago

Hi Jonathan, thanks for reporting. My efforts are currently focussed on driving BierBot Bricks forward. I'll let you here when I plan to spend some time on the original code. Please do the same (and let me know) to avoid double-work.

Cheers, Bernhard.