Introducing TH ELite LCD support

BernhardSchlegel / Brick-32

Worlds easiest and cheapest to build brewing control. Supports mashing and fermentation. Combine multiple Bricks to control higher wattages or different functions (heating, cooling, pumps). Works with smartphone, iPad, Mac, & PC.

GNU General Public License v3.0

12 stars 2 forks source link

Introducing TH ELite LCD support #11

Closed lowPerformer closed 7 months ago

lowPerformer commented 7 months ago

Hi there. There maybe is something to discuss with this pull request:

TM1621Drv is more or less a copy/paste from Tasmota/ESPHome project
Current implementation is showTemp() for Row 1 in °C or °F and a limited showText() (I was too lazy to implement all the characters and restricted it to "AFNOTU". So you can print "Auto", "on", and "off" for the Override-status of the AC relais)
Serving in loop() the LCD was very unresponsive due to the blocking character of WiFiClientSecure::connect
Thus I introduced a new CoreTask2 running on Core1 doing all the LCD stuff
I wanted the temperature reading (on the LCD) to be more responsive. So I created a new pollTemperature_interval separating it from state_main_interval

As far as I can tell, everything runs responsive and steady.

Please let me know what you think. Greetings! Niklas

BernhardSchlegel commented 7 months ago

This is soooo awesome. Thank you so much :) One thought crossed my mind, it's possible to calibrate a sensor offset in the UI to calibrate the temperature sensors:

So let me go ahead and add something like s_number_temp_0_offset to the JSON returned by the backend. Idea would be to add this to the displayed value so the display value includes the calibration offset.

What you think?

lowPerformer commented 7 months ago

Sure. Seems to be no big deal ;) Give me a hint as soon as the new data type is implemented on the backend and I will test it.

Btw: LCD print-out is always on, even on the none-display type TH Origin. I think this is without drawbacks due to the fact that both types are the same PCBs just w/o the LCD driver chip. What do you think?

BernhardSchlegel commented 7 months ago

I would close them as similar as possible. However, we could maybe disable the interval for reading the temperature when there's no display. Display driver can always be active IMHO.

BernhardSchlegel commented 7 months ago

API return value is enhanced:

{
    "error": 0,
    "error_text": "",
    "warning": 0,
    "warning_text": "",
    "next_request_ms": 15000,
    "used_for_devices": [],
    "s_number_temp_offsetcelsius_0": 0.9
}

Simply add s_number_temp_offsetcelsius_0 to the displayed value.

Thanks!

lowPerformer commented 7 months ago

Nice! I added this in current commit.

BernhardSchlegel commented 7 months ago

One last thing (sorry ....) - can you bump String global_version = "0.9.0"; to 1.0.0 ? Looking forward to flash my elite on the weekend :)