Berny23 / LD-ToyPad-Emulator

Toy Pad Emulator for Lego Dimensions (Unofficial Fan Project)
https://github.com/Berny23/LD-ToyPad-Emulator
MIT License
233 stars 41 forks source link

JSON schema check #100

Closed VladimirKuletski closed 1 year ago

VladimirKuletski commented 1 year ago

Used one of GH Actions to add schema validation for charactermap, tokenmap files. Intent is to avoid any errors, typos in such big JSON files. So each PR and commit should have smoke check statuses.

Built schemas with constructors and adjusted them manually. Feel free to reorganize directory structure your way if needed.

Last step to close #98

P.S. Probably node tests is the better place for these checks, but it's easier for me to implement it this way.

P.S.2 Will keep an eye on Action. It uses several deprecated commands. Will migrate to something else if it's not maintained properly.

Berny23 commented 1 year ago

Thank you for the work!