search

Berny23 / LD-ToyPad-Emulator

Toy Pad Emulator for Lego Dimensions (Unofficial Fan Project)
https://github.com/Berny23/LD-ToyPad-Emulator
MIT License
227 stars 41 forks source link

Relative filepaths #140

Closed l3ennji closed 1 year ago

l3ennji commented 1 year ago

Hi, upon installing, I found 3 relative filepaths within the index.js file (something like "./server/foo/bar/") which should be replaced by paths including the __dirname, as it has been done on several other occasions within the index.js file. Without this modification, calling the index.js file from any other place than the LD-ToyPad-Emulator-Directory won't work, which makes autostarting the node a pain in the ass. With this modification, it's very easy to setup a autostart routine using the pm2 command set, which is neat, because now your emulator will start as soon as you turn on your console (also, I personally think it's just not very good style to use relative filepaths).

Maybe someone can adjust those three lines.

Nevertheless, great work, thank you to everyone who has contributed to this, works like a charm.

Best regards

Benny

VladimirKuletski commented 1 year ago

Please contribute with a pull request! That will be definitely faster to get it onboarded.

l3ennji commented 1 year ago

Hi Vladimir, just did. (It's my first GitHub-Commit ever, that's why I hesitated.) I hope it works.