search

Berny23 / LD-ToyPad-Emulator

Toy Pad Emulator for Lego Dimensions (Unofficial Fan Project)
https://github.com/Berny23/LD-ToyPad-Emulator
MIT License
249 stars 43 forks source link

added pad color filter prototype #150

Closed pablo5425 closed 1 year ago

pablo5425 commented 1 year ago

index.js modified to include a switch that changes colors being generated so they display more accurately also index.html has been modified to change initial pad colors so it looks like the pad is turned off until its connected to the game

this commit might say that files content was completely replaced but this is just a strange side effect from testing them in the virtual machine

Berny23 commented 1 year ago

Your files have a line feed mismatch (CRLF, but should be LF).

Berny23 commented 1 year ago

I fixed the line feed issue, thanks for your contribution! 👍

Luigimeansme commented 1 year ago

I just ran a test on the Portal level to test out the five main keystones, and it all seems to look great! The only problem I really noticed was the orange side of Scale being dark a lot longer than it should've according to the onscreen toypad, but I don't know if that's the game sending weird info to the toypad or if it has something to do with this change, just thought it was worth mentioning

pablo5425 commented 1 year ago

I just ran a test on the Portal level to test out the five main keystones, and it all seems to look great! The only problem I really noticed was the orange side of Scale being dark a lot longer than it should've according to the onscreen toypad, but I don't know if that's the game sending weird info to the toypad or if it has something to do with this change, just thought it was worth mentioning

i had some issues with that part of the code. mostly bc i was missing some breaks just made a small check and it can be fixed by deleting the 80 in "#ff1e0080" i dont understand why central pad starts off tho. it needs a blink animation to turn white

pablo5425 commented 1 year ago

sent pull request #151 with fixed orange for scale keystone

cort1237 commented 1 year ago

i dont understand why central pad starts off tho. it needs a blink animation to turn white

I can offer a little insight. Basically the game doesn't just send straight hex values it also specifies a type of function. IIRC it's COL (Set Color), FLSH (Flash Color), FADE (Fade Color). At the moment only COL functions work, bc I didn't have working hardware with me to see exactly how to should look and 95% of the light effects are just COLs. You can see listeners for the unimplemented functions in index.js and see what data is being received if you wanna give a crack at it.