search

Berny23 / LD-ToyPad-Emulator

Toy Pad Emulator for Lego Dimensions (Unofficial Fan Project)
https://github.com/Berny23/LD-ToyPad-Emulator
MIT License
243 stars 43 forks source link

Includes custom image display for characters #208

Closed Lypsilonx closed 2 months ago

Lypsilonx commented 2 months ago

Just put your images to server/images/\<id>.png and they will be displayed instead of the name of the character

Berny23 commented 2 months ago

Thanks for your contribution!

Luigimeansme commented 2 months ago

Ok, I'm testing this out now but it doesn't appear to be working? I got an image for Batman, named it Batman.png, and placed it in server/images both with and without a folder called .png, but no image is showing. What exactly am I doing wrong @Lypsilonx?

Lypsilonx commented 2 months ago

they need to be named after the ids (because names could technically be ambiguous) so it should be called 1.png (in the case of batman)

Luigimeansme commented 2 months ago

they need to be named after the ids (because names could technically be ambiguous) so it should be called 1.png (in the case of batman)

I tried that as well, as well as having another thing in there for Gandalf named 2.png and it doesn't show up either

Lypsilonx commented 2 months ago

You can find all the ids here

Lypsilonx commented 2 months ago

thats wierd... its working on my end, so could you maybe send the error in the console or the html (inspect the figure)

Luigimeansme commented 2 months ago

image image

You can see my FTP program here where you see the folders and the files I placed in them

Lypsilonx commented 2 months ago

ah... I think you placed the files in another folder called ".png" you dont need that It might have been an issue with my initial message, where github interpreted the "id" in angle brackets I used in the path as a html tag and it was showing up as ".../.png". I fixed my message now

Lypsilonx commented 2 months ago

I have made another pull request that might fix the issue, but if that doesn't work I'm afraid it might take me a while to fix it

Luigimeansme commented 2 months ago

As soon as it's merged, I'll update and try it out

Lypsilonx commented 2 months ago

What is the url you are connecting to exactly? That might help to...

Luigimeansme commented 2 months ago

I'm just connecting to the Pi's IP address, you can see it in that image with the 404 error code

Luigimeansme commented 2 months ago

image Haha! Gottem! Good job on the fix @Lypsilonx! I'm gonna delete the image that shows my Pi's IP now, I don't feel comfortable with that being permanently on the internet