search

Berny23 / LD-ToyPad-Emulator

Toy Pad Emulator for Lego Dimensions (Unofficial Fan Project)
https://github.com/Berny23/LD-ToyPad-Emulator
MIT License
243 stars 43 forks source link

Allow tags to be dropped on the same space they were picked up from #70

Closed benlucaslaws closed 2 years ago

benlucaslaws commented 2 years ago

This PR updates the sortable event handlers to allow tags to be dragged into the same space they started in. This addresses point 1 of #49, and #24. I didn't implement this as a double click as suggested in #24 as it doesn't work well with sortable or on touchscreens.

This also mitigates some of the sync issues caused by rapidly dragging between spaces on the Toy Pad, which can remove a tag before it has been placed in its new location. It doesn't prevent it, but it is now much less likely to occur due to the fact that returning a tag to the same space was the most likely reason I've found to move a tag twice in quick succession.

Berny23 commented 2 years ago

Thanks for your contribution! 🤍

Luigimeansme commented 2 years ago

Just tested it out, and it works BEAUTIFULLY! You single handedly fixed the one major issue I still had with this program that I found irritating on replays! Thank you for the hard work, everyone who's helped make this program as great as it is!