Don't upload sensitive terminal output

BerriAI / clerkie-cli

Clerkie-cli is a terminal tool that uses an LLM to help debug and troubleshoot coding errors in any programming language. It offers explanations, suggested fixes, guidance, alternative approaches, and code examples. It is useful for developers of all skill levels.

93 stars 7 forks source link

Don't upload sensitive terminal output #2

Open nicolaschan opened 1 year ago

nicolaschan commented 1 year ago

My terminal output often contains sensitive information like a password. Some ideas to fix this:

Option to turn uploading on or off temporarily
Option for uploading to be off by default
Give a few seconds to abort clerkie upload with Ctrl-C (or conversely, give few seconds to confirm clerkie usage)
Only run clerkie on output of commands specified in an allowlist (so it might run on python but not cat)

Additionally, it could show on the PS1 whether clerkie is enabled or not.

krrishdholakia commented 1 year ago

I like the idea of having the option to have default monitoring be turned off.

This way you can opt in to when you want it to listen. While the default can be turned on (simplify onboarding + tie into the 'there when you need it/embedded workflow' usecase, users who are concerned about this, can have the choice to turn this off.

And choose to run it when you want it (e.g. clerkie python main.py)

@ishaan-jaff @nicolaschan thoughts?

nicolaschan commented 1 year ago

Opt-in makes sense. It would also be nice if you could opt-in after the error happens. I imagine often I would have it disabled by default and not anticipate an error.

An indication for whether it is enabled would also be helpful in case I forget which terminals have it enabled/disabled.

ishaan-jaff commented 1 year ago

I'm in support of building ability to summon 'clerkie' when a user requires. I think it's important for it to be default on for users to experience the value proposition, following with the ability to switch off if required.