[Bug]: register_model trigger some ugly debug prints

antoine-lizee commented 3 weeks ago

What happened?

This is a formal bug, that's quite annoying because it's flooding our logs, but it's not breaking anything.

What's happening is that when you call litellm.register_model() it tries to see if there is an existing model with the given key by calling get_model_info() which itself calls get_llm_provider() (twice!?), which has this super weird lines:

            if litellm.suppress_debug_info == False:
                print()  # noqa
                print(  # noqa
                    "\033[1;31mProvider List: https://docs.litellm.ai/docs/providers\033[0m"  # noqa
                )  # noqa
                print()  # noqa

....before building an error.

Problems I see:

1/ Registering unknown models should not trigger an error log.
- This is not going to be an easy fix given how get_llm_provider() behaves. (it tries to do too much imo)
- I see that we catch the error on the top level of register_model, we can maybe do something at this level?
2/ We should not use print behind suppress_debug_info when we have a clean logger.debug()
- Though I understand that we probably want to shout something useful to the end user regardless of the logging setup (which rarely includes debug)
3/ [small] it should be called register_models 😅

In this case, I would vote for just removing the print() statements given that the error message is quite clear and has a reference to the url already. If you catch the exception, nothing happens as expected (including when we register models) if you don't catch the exception, the error will be shown, and it's much more helpful than this print statement.

Relevant log output

Provider List: https://docs.litellm.ai/docs/providers

Provider List: https://docs.litellm.ai/docs/providers

Provider List: https://docs.litellm.ai/docs/providers

Provider List: https://docs.litellm.ai/docs/providers

Twitter / LinkedIn details

No response

krrishdholakia commented 3 weeks ago

call litellm.register_model()

Can you share a sample script for repro? @antoine-lizee

antoine-lizee commented 3 weeks ago

Not on my computer but anything like this would print it:

litellm.register_model({"some_new_model_with_unknown_or_no_provider": {...}})

I can find a better example tomorrow.

BerriAI / litellm