Berry-Club / Genetics-Resequenced

MIT License
1 stars 0 forks source link

[Bug] Matching Genes in Plasmid Infuser not giving correct amount of DNA points #18

Closed MuteTiefling closed 3 months ago

MuteTiefling commented 3 months ago

Describe the bug When using matching DNA Helixes to create Plasmids the UI will say it gives +2 DNA points towards completion but they actually only give 1 point.

Expected behavior Non Generic helixes should grant +2 progress on a plasmid

Additional context Add any other context about the problem here.

aaronhowser1 commented 3 months ago

Is it just the first one that gives 1? I should probably make that one give nothing and just set the gene, actually

aaronhowser1 commented 3 months ago
        if (DnaHelixItem.getGene(inputHelix) == ModGenes.BASIC.get()) {
            PlasmidItem.increaseAmount(outputPlasmid, 1)
            return
        } else {
            if (inputGene != plasmidGene) return
            PlasmidItem.increaseAmount(outputPlasmid, 1)
        }

yeah nope whoops, i'll fix that ty

aaronhowser1 commented 3 months ago
        when (DnaHelixItem.getGene(inputHelix)) {
            ModGenes.BASIC.get() -> PlasmidItem.increaseDnaPoints(outputPlasmid, 1)
            plasmidGene -> PlasmidItem.increaseDnaPoints(outputPlasmid, 2)
            else -> return
        }

much nicer