search

Bersaelor / KDTree

Swift implementation of a k-dimensional binary space partitioning tree.
MIT License
155 stars 27 forks source link

OS X support #2

Closed nickswalker closed 8 years ago

nickswalker commented 8 years ago

No dependency on platform specific stuff so this should be straightforward. If you don't mind I'll make a PR for this.

Bersaelor commented 8 years ago

I'd love to add OSX, and also tvOS. Go ahead and make a PR, I can only look into it again after business hours today.

Bersaelor commented 8 years ago

@nickswalker I made a PR for it in a break, as I realised there is only one file that imports UIKit for the CGPoint. Does this solve your problems: https://github.com/Bersaelor/KDTree/pull/3 ?

Maybe I should add a tvOS and a OSX example target so we can see that it works as expected and duplicate the tests. 'pod lib lint' succeeds so the project builds for those platforms.

nickswalker commented 8 years ago

Looks good! Running the tests on all platforms would help ensure nothing becomes incompatible. This or AlamoFire's would serve as a good template for this.

Bersaelor commented 8 years ago

Done, try with version 0.1.2.

If you have ideas for other improvements, my ears are open!