Closed Benjamin-Dobell closed 4 years ago
Closes #126
Save & Play still fails from time-to-time on TTS end (not accepting connections), however, this at least gets us back to functional on our end.
Looks like the underlying cause is this breaking change in Electron, and Atom hasn't updated its atom.confirm implementation (https://github.com/atom/atom/blame/1d9a4cafcf6cc288d675512db8fd984e13aab869/src/application-delegate.js#L231-L235).
atom.confirm
I'll submit a PR to Atom itself shortly.
Closes #126
Save & Play still fails from time-to-time on TTS end (not accepting connections), however, this at least gets us back to functional on our end.
Looks like the underlying cause is this breaking change in Electron, and Atom hasn't updated its
atom.confirmimplementation (https://github.com/atom/atom/blame/1d9a4cafcf6cc288d675512db8fd984e13aab869/src/application-delegate.js#L231-L235).I'll submit a PR to Atom itself shortly.