search

Berserk-Games / atom-tabletopsimulator-lua

Tabletop Simulator scripting package for Atom.
Other
36 stars 26 forks source link

Uncaught TypeError: remote.dialog.showMessageBox(...).then is not a function #132

Open mellester opened 3 years ago

mellester commented 3 years ago

[Enter steps to reproduce:]

  1. Updated to latest package
  2. Pressed Get -sripts

Atom: 1.40.0 x64 Electron: 3.1.10 OS: Microsoft Windows 10 Pro Thrown From: tabletopsimulator-lua package 12.4.3

Stack Trace

Uncaught TypeError: remote.dialog.showMessageBox(...).then is not a function

At C:\Users\Melle\.atom\packages\tabletopsimulator-lua\lib\tabletopsimulator-lua.coffee:1223

TypeError: remote.dialog.showMessageBox(...).then is not a function
    at Object.getObjects (/packages/tabletopsimulator-lua/lib/tabletopsimulator-lua.coffee:1223:8)
    at /packages/tabletopsimulator-lua/lib/tabletopsimulator-lua.coffee:901:100)
    at CommandRegistry.handleCommandEvent (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:349123)
    at CommandRegistry.dispatch (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:347598)
    at AtomEnvironment.dispatchApplicationMenuCommand (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:1:757879)
    at EventEmitter.t (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:1:765802)
    at EventEmitter.emit (events.js:182:13)

Commands

     -0:43.4.0 tabletopsimulator-lua:getObjects (div.tool-panel.tree-view)
     -0:20.7.0 tree-view:remove-project-folder (span.name.icon.icon-file-directory)
     -0:18.5.0 tabletopsimulator-lua:getObjects (div.tool-panel.tree-view)

Non-Core Packages

compare-files 0.8.1 
tabletopsimulator-lua 12.4.3

Not sure why but showMessageBox() apparently did not return a promise object. I Downgraded my version so I would not get this error anymore

Benjamin-Dobell commented 3 years ago

Yeah, this is super annoying. Electron broke backward compatibility and Atom bumped its version. Rather than downgrading this plugin, you should instead upgrade Atom to the latest release 1.52.