Berserk-Games / atom-tabletopsimulator-lua

Tabletop Simulator scripting package for Atom.
Other
36 stars 27 forks source link

#include other files should be a setting with the default as disabled #135

Open merovigiam opened 3 years ago

merovigiam commented 3 years ago

Trying to open some games from the workshop that have #include can lead to an absolute confusion to whoever is not aware of that configuration that replaces the entire code with nothing when the file does not exist and leave just the #include line on atom editor. On tabletop simulator can still be seen the whole code.

Benjamin-Dobell commented 3 years ago

Developers ought to be using #include, or better yet require, so disabling this setting by default doesn't seem like a good solution.

Seems as Atom has a warning/error system, it'd make more sense to show a warning about the fact the referenced file could not be resolved on disk.