Berted / pe

0 stars 0 forks source link

clear: No Warnings or Errors #9

Open Berted opened 1 year ago

Berted commented 1 year ago

Despite being such a destructive command that removes all information, there exists no warnings that prevents a user from accidentally deleting the data, i.e. consider a user who wants to delete an internship but mixed up delete and clear.

With no rollback feature, this can be a pretty devastating issue.

nus-pe-bot commented 1 year ago

Team's Response

image.png

Yes, we do realized that this action is destructive, and hence we decided to use a special markdown box format to highlight this to the user.

A user would most likely have read the user guide and be aware of this, because without looking at the user guide, they won't even know the clear command exist.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I find that just because the feature has been clearly stated to be dangerous for the application doesn't mean it's not a feature flaw that shouldn't be addressed at all. As stated on CS2103T's website, "type.FeatureFlaw: ...Features that work as specified by the UG but should have been designed to work differently (from the end-user's point of view) fall in this category too."

I do not find a need for clear to be done so easily without any confirmation messages at all.

What if the user happens to forget the difference between clear and delete, i.e. they use it after the summer break, some users are bound to accidentally forget between these 2 commands. The fact that clear removes everything without warning is still quite dangerous in my opinion. It's not helped that clear ignores all extraneous parameters, like those provided to delete, i.e. delete 1, doing clear 1 will clear the whole data as well instead of throwing an error to the user.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]