search

Bertinus / FLeCS

Flexible and Learnable Cell Simulator
MIT License
8 stars 1 forks source link

test for `get_edges` and `interventions` -- watch for side effects or reallocation of memory. #26

Closed josephdviviano closed 11 months ago

josephdviviano commented 1 year ago

watch for ADAM momentum updates!

Bertinus commented 1 year ago

Problems may happen when the edge parameters are set to trainable (c.f. your comment about Adam above)

Bertinus commented 1 year ago

Ideally, write a test in FLeCS/test/test_intervention.py

Bertinus commented 1 year ago

I think you need to re-initialize the optimizer whenever you intervene on the cell (because the set of parameters has changed)

Check the old version of the code where we were storing the values of momentum after intervention