search

BertrandBev / code_field

A customizable code text field supporting syntax highlighting
https://bertrandbev.github.io/code_field/
MIT License
232 stars 61 forks source link

Added onChanged callback to CodeField #23

Closed leoshusar closed 2 years ago

leoshusar commented 2 years ago

I think the onChanged callback should've been on CodeField and not CodeController. CodeController extends TextEditingController and it's possible to use addListener there. The issue for me is this callback fires on every text change, focus change etc. onChanged on CodeField fires only if the text changes, which may in many cases be more useful.

BertrandBev commented 2 years ago

Cool, that's a great addition! Can you please resolve the conflicts?

leoshusar commented 2 years ago

Should be ok now!

BertrandBev commented 2 years ago

Thanks!

leoshusar commented 2 years ago

Could you please release a new version on pub.dev? Thank you!