BertrandBev / code_field

A customizable code text field supporting syntax highlighting
https://bertrandbev.github.io/code_field/
MIT License
232 stars 61 forks source link

Make webSpaceFix default to false #61

Closed alexeyinkin closed 2 years ago

alexeyinkin commented 2 years ago

When webSpaceFix is omitted (defaults to true), CodeController.text returns text with dots. For it to return the intact text, webSpaceFix should be passed as false. But when the bug that called for this hack is fixed, we want text property to return intact text without webSpaceFix.

This will mean a breaking change when the bug is fixed, and this change will not be noticed. But we rather want it to happen now to have less problems in the future.

Another option is to make it required to force users to set it. When the bug is fixed, we will remove this property forcing users to pay attention again.

But I think it is OK to just change the default value in the next breaking release and to mention it in migration doc -- because the impact of this bug is mild.