fix: expose simplicial cholesky on sparse matrices

BertrandBev / eigen-js

⚡ Eigen-js is a port of the Eigen C++ linear algebra library

https://bertrandbev.github.io/eigen-js/#/

92 stars 15 forks source link

Closed Bangybug closed 1 year ago

Bangybug commented 1 year ago

Hi, Could you please advise how do I properly expose SimplicialCholesky from libeigen to js?

Thank you

BertrandBev commented 1 year ago

@Bangybug did you test these changes?

Bangybug commented 1 year ago

@BertrandBev I'm making a comparison test in C++ and JS, it takes some time. I will upload the test here and let you know.

Bangybug commented 1 year ago

@BertrandBev I made a test, it has two parts:

src/tests/cpp/simplicialcholesky/Tutorial_sparse_example.cpp -- taken from libeigen
src/tests/ts/simplicialcholesky/Tutorial_sparse_example.ts -- ported to Typescript I'm satisfied with the results, they are in perfect match and time profile is good.

However I have some issues with the actual organization of the test code, they are listed in /src/tests/readme.md

BertrandBev commented 1 year ago

Thanks @Bangybug for the good addition! I'll take time to add it to the interactive documentation at some point