search

BertrandBordage / django-viewsets

Avoid boring views and urls.
BSD 3-Clause "New" or "Revised" License
61 stars 9 forks source link

Consistency #2

Open Hedde opened 10 years ago

Hedde commented 10 years ago

First of, great work! I'd like to suggest a more consistent usage of trailing slashes, currently some views use them and some don't. It might also be nice to add a hook for ordering urls when plugging into certain viewsets, perhaps using Django's SortedDict.

BertrandBordage commented 10 years ago

Yes, there is indeed an inconsistency in trailing slashes. What do you suggest? In my opinion, we should only remove the trailing slash of the create view. Since ListView is some kind of directory, I find it relevant to keep the slash.

By the way, do you think we should rename the ListView url name to model_list (instead of model_index)?

With hindsight, I don't think the whole "dict idea" was good. We need something object-oriented, like what has been implemented in django-rest-framework (see https://github.com/tomchristie/django-rest-framework/blob/2.3.13/rest_framework/routers.py#L79). What do you say?

eyesee1 commented 5 years ago

big yes to routers pls, I wonder if it would be possible to use DRF's?