search

Bertverbeek4PS / bc2adls

Exporting data from Dynamics 365 Business Central to Azure data lake storage or MS Fabric lakehouse
MIT License
60 stars 23 forks source link

Add functionality to automatic check the addition of all primary key … #193

Closed acjdekorte closed 5 days ago

acjdekorte commented 6 days ago

We have recently added the functionality to ensure the addition of the primary key fields on table export. We have performed this since we running into problems with our azure data factory when not all primary key fields were present on the table export. Additionally we highlighted the Index fields in the list of fields.

We think that this might be a nice addition to the community version as well.

Bertverbeek4PS commented 5 days ago

@acjdekorte thanks for the addition! Indeed I thnk this is a good idea to always export the primary key. Moslty in Farbic or Data Lake the GUID per table is fine. But this additional is a good feature. Thanks!

acjdekorte commented 5 days ago

@Bertverbeek4PS Thank you for accepting this pullrequest. You are aware that this caused the automatic test to fail, since the new import now contained more fields (to be more precise the code field of reason code table)?

Bertverbeek4PS commented 5 days ago

@Bertverbeek4PS Thank you for accepting this pullrequest. You are aware that this caused the automatic test to fail, since the new import now contained more fields (to be more precise the code field of reason code table)?

Yes indeed. I will need to look add those tests again. Thanks for pointing me to this.